Update/set output (#90 )

* updating set-output to echo to $GITHUB_OUTPUT instead Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Update the list_pull_request 401 case (#89 )
2022-10-25 21:00:21 -06:00 · 2022-09-28 10:03:05 -06:00 · 2022-09-22 03:59:00 -06:00 · 2022-09-21 23:44:03 -07:00 · 2022-03-18 08:44:13 -06:00 · 2022-02-03 06:00:46 -07:00
11 changed files with 126 additions and 126 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,8 @@ represented by the pull requests that fixed them. Critical items to know are:
 Versions correspond with GitHub releases that can be referenced with @ using actions.

 ## [master](https://github.com/vsoch/pull-request-action/tree/master) (master)
+  - bugfix of token handling if 401 error received (missing 401 case) (1.0.21)
+  - bugfix of writing to environment file (missing newline) (1.0.19)
  - bugfix of missing from branch with scheduled run (1.0.16)
  - forgot to add assignees (1.0.15)
  - output and environment variables for PR number and return codes (1.0.5)
--- a/README.md
+++ b/README.md
@@ -50,10 +50,10 @@ Unlike standard actions, this action just uses variables from the environment.
 | PULL_REQUEST_ASSIGNEES | A list (string with spaces) of users to assign | false | unset |
 | PULL_REQUEST_REVIEWERS | A list (string with spaces) of users to assign review | false | unset |
 | PULL_REQUEST_TEAM_REVIEWERS | A list (string with spaces) of teams to assign review | false | unset |
-| PASS_ON_ERROR | Instead of failing on an error response, pass | unset |
-| PASS_IF_EXISTS | Instead of failing if the pull request already exists, pass | unset |
-| PULL_REQUEST_UPDATE | If the pull request already exists, update it | unset |
-| PULL_REQUEST_STATE | If `PULL_REQUEST_UPDATE` is true, update to this state (open, closed) | open |
+| PASS_ON_ERROR | Instead of failing on an error response, pass | false | unset |
+| PASS_IF_EXISTS | Instead of failing if the pull request already exists, pass | false | unset |
+| PULL_REQUEST_UPDATE | If the pull request already exists, update it | false | unset |
+| PULL_REQUEST_STATE | If `PULL_REQUEST_UPDATE` is true, update to this state (open, closed) | false |open |

 For `PULL_REQUEST_DRAFT`, `PASS_ON_ERROR`, `PASS_IF_EXISTS`, and `MAINTAINER_CANT_MODIFY`, these are
 treated as environment booleans. If they are defined in the environment, they trigger the
@@ -100,7 +100,9 @@ The screenshot below shows the example in action to interact with outputs in sev
 ## Examples

 Example workflows are provided in [examples](examples), and please contribute any
-examples that you might have to help other users! We will walk through a basic
+examples that you might have to help other users! You can get the same commit hashes
+and commented tags if you use the [action-updater](https://github.com/vsoch/action-updater)
+also maintained by @vsoch. We will walk through a basic
 example here for a niche case. Let's say that we are opening a pull request on the release event. This would mean
 that the payload's branch variable would be null. We would need to define `PULL_REQUEST_FROM`. How would
 we do that? We can [set environment variables](https://github.com/actions/toolkit/blob/main/docs/commands.md#environment-files) for next steps. Here is an example:
@@ -119,7 +121,7 @@ jobs:
        run: |
            # do custom parsing of your code / date to derive a branch from
            PR_BRANCH_FROM=release-v$(cat VERSION)
-            export "PULL_REQUEST_FROM_BRANCH=${PR_BRANCH_FROM}" >> $GITHUB_ENV
+            echo "PULL_REQUEST_FROM_BRANCH=${PR_BRANCH_FROM}" >> $GITHUB_ENV
      - name: pull-request-action
        uses: vsoch/pull-request-action@master
        env:
--- a/examples/assignees-example.yml
+++ b/examples/assignees-example.yml
@@ -2,16 +2,16 @@ name: Pull Request on Branch Push
 on:
  push:
    branches-ignore:
-      - devel
+    - devel
 jobs:
  auto-pull-request:
    name: PullRequestAction
    runs-on: ubuntu-latest
    steps:
-      - name: pull-request-action
-        uses: vsoch/pull-request-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          BRANCH_PREFIX: "update/"
-          PULL_REQUEST_BRANCH: "master"
-          PULL_REQUEST_ASSIGNEES: vsoch
+    - name: pull-request-action
+      uses: vsoch/pull-request-action@d703f40f3af5ae294f9816395ddf2e3d2d3feafa # 1.0.21
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        BRANCH_PREFIX: update/
+        PULL_REQUEST_BRANCH: master
+        PULL_REQUEST_ASSIGNEES: vsoch
--- a/examples/branch-from-environment.yml
+++ b/examples/branch-from-environment.yml
@@ -1,24 +1,23 @@
 name: derive-branch-from-environment

 on:
-  schedule:
-    # Weekly
-    - cron: 0 0 * * 0
+  schedule: -
+    cron: 0 0 * * 0

 jobs:
  DoSomeUpdate:
    runs-on: ubuntu-latest
    steps:
    - name: Checkout Repository
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
    - name: Install or Do Something to Change repository
      run: |
-         echo "This is a new file." >> newfile.txt
+        echo "This is a new file." >> newfile.txt

    - name: Checkout New Branch
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        BRANCH_AGAINST: "master"
+        BRANCH_AGAINST: master
      run: |
        printf "GitHub Actor: ${GITHUB_ACTOR}\n"
        export BRANCH_FROM="update/newfile-$(date '+%Y-%m-%d')"
@@ -43,7 +42,7 @@ jobs:
        echo "PULL_REQUEST_FROM_BRANCH=${BRANCH_FROM}" >> $GITHUB_ENV

    - name: Open Pull Request
-      uses: vsoch/pull-request-action@master
+      uses: vsoch/pull-request-action@d703f40f3af5ae294f9816395ddf2e3d2d3feafa # 1.0.21
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        PULL_REQUEST_BRANCH: "master"
+        PULL_REQUEST_BRANCH: master
--- a/examples/custom-body-example.yml
+++ b/examples/custom-body-example.yml
@@ -2,8 +2,8 @@ name: Hotfix Branch Pull Request
 on:
  push:
    branches-ignore:
-      - master
-      - production
+    - master
+    - production

 # See https://github.com/vsoch/pull-request-action/issues/47#issuecomment-707109132

@@ -12,44 +12,44 @@ jobs:
    name: PullRequestAction
    runs-on: ubuntu-latest
    steps:
-      - name: Generate branch name
-        uses: actions/github-script@v3
-        id: set-branch-name
-        with:
-          script: |
-            const capitalize = (name) => name.charAt(0).toUpperCase() + name.slice(1);
-            const emoji = context.payload.ref.startsWith("refs/heads/feature")
-              ? "✨ "
-              : context.payload.ref.startsWith("refs/heads/hotfix")
-              ? "🚑 "
-              : "";
-            return `${emoji}${capitalize(
-              context.payload.ref
-                .replace("refs/heads/", "")
-                .replace(/-/g, " ")
-                .replace("feature ", "")
-                .replace("hotfix ", "")
-            )}`;
-          result-encoding: string
-      - name: Set branch name
-        run: echo "PULL_REQUEST_TITLE=${{steps.set-branch-name.outputs.result}}" >> $GITHUB_ENV
-      - name: Generate PR body
-        uses: actions/github-script@v3
-        id: set-pr-body
-        with:
-          script: |
-            return `I'm opening this pull request for this branch, pushed by @${
-              context.payload.head_commit.author.username
-            } with ${context.payload.commits.length} commit${
-              context.payload.commits.length === 1 ? "" : "s"
-            }.`;
-          result-encoding: string
-      - name: Set PR body
-        run: echo "PULL_REQUEST_BODY=${{steps.set-pr-body.outputs.result}}" >> $GITHUB_ENV
-      - name: pull-request-action
-        uses: vsoch/pull-request-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          BRANCH_PREFIX: "hotfix-"
-          PULL_REQUEST_BRANCH: "production"
-          PULL_REQUEST_REVIEWERS: "AnandChowdhary"
+    - name: Generate branch name
+      uses: actions/github-script@v6
+      id: set-branch-name
+      with:
+        script: |
+          const capitalize = (name) => name.charAt(0).toUpperCase() + name.slice(1);
+          const emoji = context.payload.ref.startsWith("refs/heads/feature")
+            ? "✨ "
+            : context.payload.ref.startsWith("refs/heads/hotfix")
+            ? "🚑 "
+            : "";
+          return `${emoji}${capitalize(
+            context.payload.ref
+              .replace("refs/heads/", "")
+              .replace(/-/g, " ")
+              .replace("feature ", "")
+              .replace("hotfix ", "")
+          )}`;
+        result-encoding: string
+    - name: Set branch name
+      run: echo "PULL_REQUEST_TITLE=${{steps.set-branch-name.outputs.result}}" >> $GITHUB_ENV
+    - name: Generate PR body
+      uses: actions/github-script@v6
+      id: set-pr-body
+      with:
+        script: |
+          return `I'm opening this pull request for this branch, pushed by @${
+            context.payload.head_commit.author.username
+          } with ${context.payload.commits.length} commit${
+            context.payload.commits.length === 1 ? "" : "s"
+          }.`;
+        result-encoding: string
+    - name: Set PR body
+      run: echo "PULL_REQUEST_BODY=${{steps.set-pr-body.outputs.result}}" >> $GITHUB_ENV
+    - name: pull-request-action
+      uses: vsoch/pull-request-action@d703f40f3af5ae294f9816395ddf2e3d2d3feafa # 1.0.21
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        BRANCH_PREFIX: hotfix-
+        PULL_REQUEST_BRANCH: production
+        PULL_REQUEST_REVIEWERS: AnandChowdhary
--- a/examples/outputs-example.yml
+++ b/examples/outputs-example.yml
@@ -2,27 +2,27 @@ name: Pull Request on Branch Push
 on:
  push:
    branches-ignore:
-      - devel
+    - devel
 jobs:
  auto-pull-request:
    name: PullRequestAction
    runs-on: ubuntu-latest
    steps:
-      - name: pull-request-action
-        id: pull_request
-        uses: vsoch/pull-request-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          BRANCH_PREFIX: "update/"
-          PULL_REQUEST_BRANCH: "master"
-          PULL_REQUEST_REVIEWERS: vsoch
-      - name: Test outputs
-        env:
-          pull_request_number_output: ${{ steps.pull_request.outputs.pull_request_number }}
-          pull_request_url_output: ${{ steps.pull_request.outputs.pull_request_url }}
-        run: |
-          echo "Pull request number from output: ${pull_request_number_output}"
-          echo "Pull request url from output: ${pull_request_url_output}"
-          echo "Pull request number from environment: ${PULL_REQUEST_NUMBER}"
-          echo "Pull request url from environment: ${PULL_REQUEST_URL}"
-          echo "Another way to specify from output ${{ steps.pull_request.outputs.pull_request_number }}"
+    - name: pull-request-action
+      id: pull_request
+      uses: vsoch/pull-request-action@d703f40f3af5ae294f9816395ddf2e3d2d3feafa # 1.0.21
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        BRANCH_PREFIX: update/
+        PULL_REQUEST_BRANCH: master
+        PULL_REQUEST_REVIEWERS: vsoch
+    - name: Test outputs
+      env:
+        pull_request_number_output: ${{ steps.pull_request.outputs.pull_request_number }}
+        pull_request_url_output: ${{ steps.pull_request.outputs.pull_request_url }}
+      run: |
+        echo "Pull request number from output: ${pull_request_number_output}"
+        echo "Pull request url from output: ${pull_request_url_output}"
+        echo "Pull request number from environment: ${PULL_REQUEST_NUMBER}"
+        echo "Pull request url from environment: ${PULL_REQUEST_URL}"
+        echo "Another way to specify from output ${{ steps.pull_request.outputs.pull_request_number }}"
--- a/examples/push-example.yml
+++ b/examples/push-example.yml
@@ -2,17 +2,17 @@ name: Pull Request on Branch Push
 on:
  push:
    branches-ignore:
-      - staging
-      - launchpad
-      - production
+    - staging
+    - launchpad
+    - production
 jobs:
  auto-pull-request:
    name: PullRequestAction
    runs-on: ubuntu-latest
    steps:
-      - name: pull-request-action
-        uses: vsoch/pull-request-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          BRANCH_PREFIX: "update/"
-          PULL_REQUEST_BRANCH: "master"
+    - name: pull-request-action
+      uses: vsoch/pull-request-action@d703f40f3af5ae294f9816395ddf2e3d2d3feafa # 1.0.21
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        BRANCH_PREFIX: update/
+        PULL_REQUEST_BRANCH: master
--- a/examples/release-example.yml
+++ b/examples/release-example.yml
@@ -1,7 +1,7 @@
 on:
  release:
    types:
-      - published
+    - published

 jobs:
  persist-new-suite-yml:
@@ -18,31 +18,27 @@ jobs:
        version=$(echo "$tag_name" | sed 's/^v//')
        echo "Version: $version"

-        echo "::set-output name=suite_version::${version}"
-        echo "::set-output name=suite_update_branch::suite_${version}"
+        echo "suite_version=${version}" >> $GITHUB_OUTPUT
+        echo "suite_update_branch=suite_${version}" >> $GITHUB_OUTPUT
      id: data

    - name: Permanently save the new suite release
      run: |
        mkdir -p releases
-
        new_suite_version_yml="releases/suite_${{ steps.data.outputs.suite_version }}.yml"
        echo "Suite target file: $new_suite_version_yml"
-
        cp suite.yml "${new_suite_version_yml}"
-
        git add "${new_suite_version_yml}"
        git commit -m "Suite v${{ steps.data.outputs.suite_version }} auto-commit of new release files"

    - name: Push files
-      run: |
-        git push --force "https://${{ github.actor }}:${{secrets.GITHUB_TOKEN}}@github.com/${{ github.repository }}.git" "HEAD:${{ steps.data.outputs.suite_update_branch }}"
+      run: git push --force "https://${{ github.actor }}:${{secrets.GITHUB_TOKEN}}@github.com/${{ github.repository }}.git" "HEAD:${{ steps.data.outputs.suite_update_branch }}"

    - name: Open a PR to the default branch
-      uses: vsoch/pull-request-action@master
+      uses: vsoch/pull-request-action@d703f40f3af5ae294f9816395ddf2e3d2d3feafa # 1.0.21
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        PULL_REQUEST_FROM_BRANCH: "${{ steps.data.outputs.suite_update_branch }}"
+        PULL_REQUEST_FROM_BRANCH: ${{ steps.data.outputs.suite_update_branch }}
        PULL_REQUEST_BRANCH: master
-        PULL_REQUEST_TITLE: "Action: Update suite release file for v${{ steps.data.outputs.suite_version }}"
-        PULL_REQUEST_BODY: "Auto-generated PR!"
+        PULL_REQUEST_TITLE: 'Action: Update suite release file for v${{ steps.data.outputs.suite_version }}'
+        PULL_REQUEST_BODY: Auto-generated PR!
--- a/examples/reviewers-example.yml
+++ b/examples/reviewers-example.yml
@@ -2,16 +2,16 @@ name: Pull Request on Branch Push
 on:
  push:
    branches-ignore:
-      - devel
+    - devel
 jobs:
  auto-pull-request:
    name: PullRequestAction
    runs-on: ubuntu-latest
    steps:
-      - name: pull-request-action
-        uses: vsoch/pull-request-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          BRANCH_PREFIX: "update/"
-          PULL_REQUEST_BRANCH: "master"
-          PULL_REQUEST_REVIEWERS: vsoch
+    - name: pull-request-action
+      uses: vsoch/pull-request-action@d703f40f3af5ae294f9816395ddf2e3d2d3feafa # 1.0.21
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        BRANCH_PREFIX: update/
+        PULL_REQUEST_BRANCH: master
+        PULL_REQUEST_REVIEWERS: vsoch
--- a/img/open-source-halloween-2021.png
+++ b/img/open-source-halloween-2021.png
--- a/pull-request.py
+++ b/pull-request.py
@@ -79,7 +79,7 @@ def set_env(name, value):
    environment_file_path = os.environ.get("GITHUB_ENV")

    with open(environment_file_path, "a") as environment_file:
-        environment_file.write("%s=%s" % (name, value))
+        environment_file.write("%s=%s\n" % (name, value))


 def open_pull_request(title, body, target, source, is_draft=False, can_modify=True):
@@ -160,11 +160,11 @@ def set_pull_request_groups(response):
    html_url = response.get("html_url")
    print("Number opened for PR is %s" % number)
    set_env("PULL_REQUEST_NUMBER", number)
-    print("::set-output name=pull_request_number::%s" % number)
+    print("pull_request_number=%s >> $GITHUB_OUTPUT" % number)
    set_env("PULL_REQUEST_RETURN_CODE", pull_request_return_code)
-    print("::set-output name=pull_request_return_code::%s" % pull_request_return_code)
+    print("pull_request_return_code=%s >> $GITHUB_OUTPUT" % pull_request_return_code)
    set_env("PULL_REQUEST_URL", html_url)
-    print("::set-output name=pull_request_url::%s" % html_url)
+    print("pull_request_url=%s >> $GITHUB_OUTPUT" % html_url)


 def list_pull_requests(target, source):
@@ -180,8 +180,8 @@ def list_pull_requests(target, source):
    print("Params for checking if pull request exists: %s" % params)
    response = requests.get(PULLS_URL, params=params)

-    # Case 1: 404 might warrant needing a token
-    if response.status_code == 404:
+    # Case 1: 401, 404 might warrant needing a token
+    if response.status_code in [401, 404]:
        response = requests.get(PULLS_URL, params=params, headers=HEADERS)
    if response.status_code != 200:
        abort_if_fail(response, "Unable to retrieve information about pull requests")
@@ -216,7 +216,7 @@ def add_assignees(entry, assignees):
    print(response.json())
    print("::endgroup::github assignees response")
    set_env("ASSIGNEES_RETURN_CODE", assignees_return_code)
-    print("::set-output name=assignees_return_code::%s" % assignees_return_code)
+    print("assignees_return_code=%s >> $GITHUB_OUTPUT" % assignees_return_code)


 def find_pull_request(listing, source):
@@ -235,12 +235,11 @@ def find_pull_request(listing, source):


 def find_default_branch():
-    """Find default branch for a repo (only called if branch not provided)
-    """
+    """Find default branch for a repo (only called if branch not provided)"""
    response = requests.get(REPO_URL)

-    # Case 1: 404 might need a token
-    if response.status_code == 404:
+    # Case 1: 401, 404 might need a token
+    if response.status_code in [401, 404]:
        response = requests.get(REPO_URL, headers=HEADERS)
    if response.status_code != 200:
        abort_if_fail(response, "Unable to retrieve default branch")
@@ -274,7 +273,7 @@ def add_reviewers(entry, reviewers, team_reviewers):
    print(response.json())
    print("::endgroup::github reviewers response")
    set_env("REVIEWERS_RETURN_CODE", reviewers_return_code)
-    print("::set-output name=reviewers_return_code::%s" % reviewers_return_code)
+    print("reviewers_return_code=%s >> $GITHUB_OUTPUT" % reviewers_return_code)
    print("Add reviewers return code: %s" % reviewers_return_code)


@@ -283,7 +282,9 @@ def add_reviewers(entry, reviewers, team_reviewers):
 ################################################################################

 API_VERSION = "v3"
-BASE = "https://api.github.com"
+
+# Allow for a GitHub enterprise URL
+BASE = os.environ.get("GITHUB_API_URL") or "https://api.github.com"

 PR_TOKEN = os.environ.get("PULL_REQUEST_TOKEN") or get_envar("GITHUB_TOKEN")
 PR_REPO = os.environ.get("PULL_REQUEST_REPOSITORY") or get_envar("GITHUB_REPOSITORY")
Author	SHA1	Message	Date
Vanessasaurus	50f22f6d14	Update/set output (#90 ) * updating set-output to echo to $GITHUB_OUTPUT instead Signed-off-by: vsoch <vsoch@users.noreply.github.com>	2022-10-25 21:00:21 -06:00
Yunqi(Alice)	d703f40f3a	Update the list_pull_request 401 case (#89 ) * Update the list_pull_request 401 case Hi, I find this http request is also missing the 401 case. * Update CHANGELOG.md	2022-09-28 10:03:05 -06:00
Vanessasaurus	415544869c	Merge pull request #88 from ohenak/fix/ghe-get-401-error [Chore] Provide token when getting 401 error	2022-09-22 03:59:00 -06:00
Kane Ho	667293445b	[Chore] Provide token when getting 401 error Issue #87 In GHE, token is necessary when querying the repo API, When it fails, it returns 401 error. Will need to specify the token in this case.	2022-09-21 23:44:03 -07:00
Felix Breidenstein	e64deeba68	Fix example in README (#85 )	2022-03-18 08:44:13 -06:00
Vanessasaurus	58a078aed9	Update CHANGELOG.md	2022-02-03 06:00:46 -07:00
Sviatoslav Sydorenko	408336c607	Fix emitting LF-separated GHA environment vars (#84 ) Fixes #83 (hopefully)	2022-02-03 05:59:59 -07:00
Vanessasaurus	d99aa3ed71	Adding quick option to be able to specify a GitHub enterprise url (#80 ) * adding quick option to be able to specify a GitHub enterprise url Signed-off-by: vsoch <vsoch@users.noreply.github.com> * Use GITHUB_API_URL instead Co-authored-by: Tobias <github@tobiasgabriel.de> * Update README.md * Update pull-request.py Co-authored-by: vsoch <vsoch@users.noreply.github.com> Co-authored-by: Tobias <github@tobiasgabriel.de>	2021-10-02 22:40:48 -06:00
Vanessasaurus	a48b660567	Merge pull request #81 from vsoch/add/open-source-halloween-2021 adding open source halloween!	2021-10-02 18:26:20 -06:00
vsoch	4b09070b0a	adding open source halloween! Signed-off-by: vsoch <vsoch@users.noreply.github.com>	2021-10-02 18:25:26 -06:00