Public/pull-request-action
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: Public:1.0.20
Branches Tags
Public:master Public:add/retry Public:v1 Public:add/failure-verbosity Public:update/yaml-syntax
Public:1.1.1 Public:1.1.0 Public:1.0.24 Public:1.0.23 Public:1.0.22 Public:1.0.21 Public:1.0.20 Public:1.0.19 Public:1.0.18 Public:1.0.17 Public:1.0.16 Public:1.0.15 Public:1.0.14 Public:1.0.13 Public:1.0.12 Public:1.0.11 Public:1.0.10 Public:1.0.2 Public:1.0.1 Public:1.0.0
..
compare: Public:1.0.21
Branches Tags
Public:master Public:add/retry Public:v1 Public:add/failure-verbosity Public:update/yaml-syntax
Public:1.1.1 Public:1.1.0 Public:1.0.24 Public:1.0.23 Public:1.0.22 Public:1.0.21 Public:1.0.20 Public:1.0.19 Public:1.0.18 Public:1.0.17 Public:1.0.16 Public:1.0.15 Public:1.0.14 Public:1.0.13 Public:1.0.12 Public:1.0.11 Public:1.0.10 Public:1.0.2 Public:1.0.1 Public:1.0.0

1 Commits
1.0.20 ... 1.0.21

Author SHA1 Message Date
Yunqi(Alice)
d703f40f3a Update the list_pull_request 401 case (#89) 
* Update the list_pull_request 401 case
Hi, I find this http request is also missing the 401 case.
* Update CHANGELOG.md
 2022-09-28 10:03:05 -06:00
2 changed files with 4 additions and 3 deletions
Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -14,6 +14,7 @@ represented by the pull requests that fixed them. Critical items to know are:
Versions correspond with GitHub releases that can be referenced with @ using actions. Versions correspond with GitHub releases that can be referenced with @ using actions.
## [master](https://github.com/vsoch/pull-request-action/tree/master) (master) ## [master](https://github.com/vsoch/pull-request-action/tree/master) (master)
- bugfix of token handling if 401 error received (missing 401 case) (1.0.21)
- bugfix of writing to environment file (missing newline) (1.0.19) - bugfix of writing to environment file (missing newline) (1.0.19)
- bugfix of missing from branch with scheduled run (1.0.16) - bugfix of missing from branch with scheduled run (1.0.16)
- forgot to add assignees (1.0.15) - forgot to add assignees (1.0.15)

6
pull-request.py
View File

@@ -180,8 +180,8 @@ def list_pull_requests(target, source):
print("Params for checking if pull request exists: %s" % params) print("Params for checking if pull request exists: %s" % params)
response = requests.get(PULLS_URL, params=params) response = requests.get(PULLS_URL, params=params)
# Case 1: 404 might warrant needing a token # Case 1: 401, 404 might warrant needing a token
if response.status_code == 404: if response.status_code in [401, 404]:
response = requests.get(PULLS_URL, params=params, headers=HEADERS) response = requests.get(PULLS_URL, params=params, headers=HEADERS)
if response.status_code != 200: if response.status_code != 200:
abort_if_fail(response, "Unable to retrieve information about pull requests") abort_if_fail(response, "Unable to retrieve information about pull requests")
@@ -238,7 +238,7 @@ def find_default_branch():
"""Find default branch for a repo (only called if branch not provided)""" """Find default branch for a repo (only called if branch not provided)"""
response = requests.get(REPO_URL) response = requests.get(REPO_URL)
# Case 1: 404 might need a token # Case 1: 401, 404 might need a token
if response.status_code in [401, 404]: if response.status_code in [401, 404]:
response = requests.get(REPO_URL, headers=HEADERS) response = requests.get(REPO_URL, headers=HEADERS)
if response.status_code != 200: if response.status_code != 200: