From 2dd37b09ab99a344bc0017fdef8818238c90d5ec Mon Sep 17 00:00:00 2001 From: David Velez Date: Thu, 22 Jul 2021 10:17:52 -0500 Subject: [PATCH 1/3] This fixes #24. Looking at aioredis library, the client.py keyword for set is now 'ex', not 'expire'. Tested this fix and fast-cache now works without issue. --- fastapi_cache/backends/redis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fastapi_cache/backends/redis.py b/fastapi_cache/backends/redis.py index be67d3f..c82cdd9 100644 --- a/fastapi_cache/backends/redis.py +++ b/fastapi_cache/backends/redis.py @@ -19,7 +19,7 @@ class RedisBackend(Backend): return await self.redis.get(key) async def set(self, key: str, value: str, expire: int = None): - return await self.redis.set(key, value, expire=expire) + return await self.redis.set(key, value, ex=expire) async def clear(self, namespace: str = None, key: str = None) -> int: if namespace: From 3dc2b53e4171805c4f3354f6d929ff4ead00b976 Mon Sep 17 00:00:00 2001 From: David Velez Date: Thu, 22 Jul 2021 10:47:02 -0500 Subject: [PATCH 2/3] Updated changelog and version for the project. --- CHANGELOG.md | 4 ++++ pyproject.toml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9e35c97..6fcda14 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## 0.1 +### 0.1.5 +- Fix setting expire for redis (#24) +- Update expire key + ### 0.1.4 - Fix default expire for memcached. (#13) diff --git a/pyproject.toml b/pyproject.toml index 317c9f6..4486888 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "fastapi-cache2" -version = "0.1.4" +version = "0.1.4.1" description = "Cache for FastAPI" authors = ["long2ice "] license = "Apache-2.0" From 57fe4ce24b9f74ad366fcdfae8f880a08e0fbef0 Mon Sep 17 00:00:00 2001 From: David Velez Date: Thu, 22 Jul 2021 10:54:10 -0500 Subject: [PATCH 3/3] Updated changelog to 1.4 from 1.5 --- CHANGELOG.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6fcda14..86d91c7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,12 +2,10 @@ ## 0.1 -### 0.1.5 -- Fix setting expire for redis (#24) -- Update expire key - ### 0.1.4 +- Fix setting expire for redis (#24) +- Update expire key - Fix default expire for memcached. (#13) - Update default key builder. (#12)